Skip to content

[ui] Fix field of view functions for tall images #2609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2024
Merged

[ui] Fix field of view functions for tall images #2609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions meshroom/ui/reconstruction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,11 +361,18 @@ def fieldOfView(self):
if not self.solvedIntrinsics:
return None
focalLength = self.solvedIntrinsics["focalLength"]

#We assume that if the width is less than the weight
#It's because the image has been rotated and not
#because the sensor has some unusual shape
sensorWidth = self.solvedIntrinsics["sensorWidth"]
sensorHeight = self.solvedIntrinsics["sensorHeight"]
if self.imageSize.height() > self.imageSize.width():
sensorWidth, sensorHeight = sensorHeight, sensorWidth

if self.orientation in (5, 6, 7, 8):
sensorWidth = self.solvedIntrinsics["sensorWidth"]
return 2.0 * math.atan(float(sensorWidth) / (2.0 * float(focalLength))) * 180.0 / math.pi
else:
sensorHeight = self.solvedIntrinsics["sensorHeight"]
return 2.0 * math.atan(float(sensorHeight) / (2.0 * float(focalLength))) * 180.0 / math.pi

@Property(type=QUrl, notify=undistortedImageParamsChanged)
Expand Down