[GraphEditor] Edge: Correctly update the EdgeMouseArea when moving nodes
#2613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann-lty
reviewed
Dec 3, 2024
cbentejac
force-pushed
the
fix/edgeSelection
branch
from
bdaf330 to
0dca19f
Compare
yann-lty
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request correctly updates the mouse area over edges when nodes these edges are connected to have been moved.
Prior to it, the mouse area of each edge was set once and never updated afterwards, meaning the edge remained selectable if and only if it did not move too much from its original position. The curve scale of the mouse area is now recomputed every single time the size of its edge has changed (i.e. whenever a node it is connected to has been moved).