-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[docker] Add Dockerfiles for Rocky 9 and handle Qt 6 installation #2626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #2626 +/- ##
===========================================
- Coverage 78.57% 77.80% -0.77%
===========================================
Files 48 48
Lines 6577 6674 +97
===========================================
+ Hits 5168 5193 +25
- Misses 1409 1481 +72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thank you for this great PR. I am new to Meshroom, I would like to know more about the Docker infrastructure design and eventually contribute to the project as well. For AliceVision and Meshroom, why are we using a Why not directly include those calls in the I am happy to create a PR if needed. |
|
Why not add the environment variables inside the docker as well? export ALICEVISION_ROOT=/opt/AliceVision_install
export ALICEVISION_SENSOR_DB=/opt/AliceVision_install/share/aliceVision/cameraSensors.db
export ALICEVISION_VOCTREE=/opt/AliceVision_install/share/aliceVision/vlfeat_K80L3.SIFT.tree
export ALICEVISION_SPHERE_DETECTION_MODEL=/opt/AliceVision_install/share/aliceVision/sphereDetection_Mask-RCNN.onnx
export ALICEVISION_SEMANTIC_SEGMENTATION_MODEL=/opt/AliceVision_install/share/aliceVision/fcn_resnet50.onnx
export PATH=$PATH:/opt/AliceVision_install/bin
export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/opt/AliceVision_install/lib |
|
@cbentejac since alicevision uses the 22.04 image now and these changes seem due, do you think these will be merged in the near future? |
|
@cbentejac do you think this PR will make it in the develop branch anytime soon? |
|
@cbentejac @nicolas-lambert-tc I don't know how you build, but Alicevision already uses these Images, so i think it Meshroom should follow like it is intended in this PR. |
|
Hi @hiaselhans, Yes, this PR will be merged soon! I need to slightly rework it before we do, though. I'm converting it to "draft" until then. |
3c667cb to
7921503
Compare
7921503 to
71597c4
Compare
The installation of plugins will be handled separately, and not directly in Meshroom's images.
Description
This PR updates the Dockerfiles for Meshroom as follows:
Features list