Extract more metadata using exifTool #2645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2645 +/- ##
===========================================
- Coverage 69.93% 69.42% -0.51%
===========================================
Files 121 123 +2
Lines 7088 7167 +79
===========================================
+ Hits 4957 4976 +19
- Misses 2131 2191 +60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
servantftransperfect
left a comment
servantftransperfect
left a comment
There was a problem hiding this comment.
- I got non explicit errors if nothing is connected to the node
- Nothing appears in the log if exiftool is not found
- On Error, the node does not fail.
servantftransperfect
approved these changes
Feb 5, 2025
fabiencastan
added
the
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a pure python node dedicated to extract metadata from image files using exifTool. This node can be connected to the cameraInit node and for all images referenced in the "cameraInit.sfm" file, if exifTool is available, a file containing all metadata is generated. The file format can be selected amongst "txt", "xmp", "xml". Be aware that the "xmp" format cannot store all metadata contained in the image file.
Features list
Implementation remarks
The invocated exifTool command depends on the requested file format in the following way:
exiftool [args] imageFile > metadataFile.txtexiftool -X [args] imageFile > metadataFile.xmlexiftool -tagsfromfile imageFile [args] metadataFile.xmpOptional arguments 'args' can be defined through a string parameter of the meshroom node.
The boolean parameter "keepfilename" allows to keep the image file name for the metadata file but changing the file extension.