Enable Fitting of selected Nodes in the Graph Editor when Fit is invoked #2652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pressing F or invoking GraphEditor.fit() now considers the selected nodes and fits/focusses on the overall selection if present, else fits/focusses all of available nodes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2652 +/- ##
========================================
Coverage 69.93% 69.93%
========================================
Files 121 121
Lines 7088 7088
========================================
Hits 4957 4957
Misses 2131 2131 ☔ View full report in Codecov by Sentry. |
fabiencastan
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds functionality to consider the Selected Nodes when calling
fitin the GraphEditor.This change ensures that if there is a node selection available, GraphEditor is fit to the selected Nodes and if not, the fit considers all of the available nodes in the Graph to fit to that bounding box.
Implementation Details
Considering the selectedNodes' bounding box when a node selection exists to reuse the same shortcut
F