Skip to content

Conversation

@cbentejac
Copy link
Contributor

@cbentejac cbentejac commented Mar 18, 2025

Description

This prevents reducing the Node Editor and the Graph Editor tab panel up to the point where components within them (especially those in the Node Editor's header) are disappearing from screen.

@cbentejac cbentejac added this to the Meshroom 2025.1.0 milestone Mar 18, 2025
@cbentejac cbentejac requested a review from fabiencastan March 18, 2025 15:52
@cbentejac cbentejac self-assigned this Mar 18, 2025
@cbentejac cbentejac added the UI label Mar 18, 2025
@codecov
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.08%. Comparing base (c2f3115) to head (0ad4a49).
⚠️ Report is 5 commits behind head on develop.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2699   +/-   ##
========================================
  Coverage    79.08%   79.08%           
========================================
  Files           51       51           
  Lines         6889     6889           
========================================
  Hits          5448     5448           
  Misses        1441     1441           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@Alxiice Alxiice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay after rebase, but maybe also increase the minimumWidth for the TabPanel

@cbentejac cbentejac force-pushed the fix/splitViewNodeEditor branch from bc91bab to 0ad4a49 Compare September 17, 2025 12:52
@cbentejac
Copy link
Contributor Author

Okay after rebase, but maybe also increase the minimumWidth for the TabPanel

Done!

@cbentejac cbentejac changed the title [ui] NodeEditor: Don't allow to reduce split view size below 350 [ui] GraphEditor: Don't allow to reduce split view size below 350 Sep 18, 2025
@cbentejac cbentejac merged commit cd0601a into develop Sep 18, 2025
5 checks passed
@cbentejac cbentejac deleted the fix/splitViewNodeEditor branch September 18, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants