Modernize to python 3.9 using flynt and pyupgrade#2710
Merged
Conversation
fabiencastan
changed the title
fabiencastan
force-pushed
the
dev/fstring
branch
from
9c03cde to
6764862
Compare
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## develop #2710 +/- ##
========================================
Coverage 76.75% 76.75%
========================================
Files 40 40
Lines 6082 6083 +1
========================================
+ Hits 4668 4669 +1
Misses 1414 1414 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes parts of the Meshroom codebase to Python 3.9 by removing legacy coding comments, adopting f-string syntax, and streamlining super() calls. Key changes include the removal of “# coding:utf-8” headers, replacing all .format() style string formatting with f-strings, and simplifying superclass invocation.
Reviewed Changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| meshroom/submitters/simpleFarmSubmitter.py | Modernized constructor and logging statements with f-strings |
| meshroom/submitters/init.py | Removed obsolete encoding header |
| meshroom/nodes/general/Publish.py | Converted string formatting to f-strings in log messages |
| meshroom/multiview.py | Updated exception message to use f-string |
| meshroom/core/test.py | Updated print statements with f-strings |
| meshroom/core/taskManager.py | Replaced legacy super() calls and string formatting |
| meshroom/core/submitter.py | Used simplified super() call |
| meshroom/core/stats.py | Converted logging formatting to f-strings and f-string formatting for paths |
| meshroom/core/nodeFactory.py | Updated import modifications and type handling |
| meshroom/core/node.py | Replaced deprecated WindowsError with OSError and modernized logging and super() usage |
| meshroom/core/graphIO.py | Converted list/set construction and string formatting to f-strings |
| meshroom/core/graph.py | Modernized overall string formatting, super() calls, and error messages |
| meshroom/core/exception.py | Adopted f-string style for error messages |
| meshroom/core/desc/node.py | Updated exception messages in chunk command execution |
| meshroom/core/cgroup.py | Simplified file opening syntax |
| meshroom/core/attribute.py | Modernized f-string usage in attribute methods and error messages |
| meshroom/core/init.py | Removed legacy encoding header and modernized Version logic |
| meshroom/common/qt.py | Updated QObjectListModel and QTypedObjectListModel to use f-strings and simplified super() calls |
| meshroom/common/core.py | Switched to modern super() calls in CoreProperty/CoreObject |
| meshroom/common/PySignal.py | Modernized signal string formatting using f-strings |
cbentejac
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.