[bin] meshroom_batch: Stop using removed defaultCacheFolder#2715
Merged
servantftransperfect merged 1 commit intodevelopfrom Apr 30, 2025
Merged
[bin] meshroom_batch: Stop using removed defaultCacheFolder#2715servantftransperfect merged 1 commit intodevelopfrom
meshroom_batch: Stop using removed defaultCacheFolder#2715servantftransperfect merged 1 commit intodevelopfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #2715 +/- ##
========================================
Coverage 76.75% 76.75%
========================================
Files 40 40
Lines 6082 6082
========================================
Hits 4668 4668
Misses 1414 1414 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
servantftransperfect
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following the removal of
meshroom.core.defaultCacheFolderin #2703, this PR removes it fully frommeshroom_batch, which kept on using it as the default value for the--cacheoption. Instead,""is used as a default value, as it is inmeshroom.core.