Skip to content

[bin] meshroom_batch: Stop using removed defaultCacheFolder#2715

Merged
servantftransperfect merged 1 commit intodevelopfrom
fix/defaultCacheFolderBatch
Apr 30, 2025
Merged

[bin] meshroom_batch: Stop using removed defaultCacheFolder#2715
servantftransperfect merged 1 commit intodevelopfrom
fix/defaultCacheFolderBatch

Conversation

@cbentejac
Copy link
Copy Markdown
Contributor

Description

Following the removal of meshroom.core.defaultCacheFolder in #2703, this PR removes it fully from meshroom_batch, which kept on using it as the default value for the --cache option. Instead, "" is used as a default value, as it is in meshroom.core.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.75%. Comparing base (006288a) to head (5afd2c1).
Report is 2 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2715   +/-   ##
========================================
  Coverage    76.75%   76.75%           
========================================
  Files           40       40           
  Lines         6082     6082           
========================================
  Hits          4668     4668           
  Misses        1414     1414           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@servantftransperfect servantftransperfect merged commit 37a6d9e into develop Apr 30, 2025
5 checks passed
@servantftransperfect servantftransperfect deleted the fix/defaultCacheFolderBatch branch April 30, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants