Skip to content

[ui] AttributeEditor: Feature/attribute navigation buttons#2716

Merged
fabiencastan merged 20 commits intodevelopfrom
feature/attribute-navigation
May 13, 2025
Merged

[ui] AttributeEditor: Feature/attribute navigation buttons#2716
fabiencastan merged 20 commits intodevelopfrom
feature/attribute-navigation

Conversation

@nicolas-lambert-tc
Copy link
Copy Markdown
Contributor

@nicolas-lambert-tc nicolas-lambert-tc commented May 2, 2025

Description

Add navigation buttons around attributes label in the AttributeEditor

nav_buttons

If an attribute have linked attributes:

  • a button appear on the left of the label, for input attributes
  • a button appear on the right of the label, for output attributes

Features list

  • Add navigation buttons on linked attributes, in the AttributeEditor
  • On clicked, the linked attributes nodes are selected in the GraphEditor
  • MiddleClick select the linked nodes and fit the view (not by default, because it can break current user workflow)
  • When many attributes are connected, a context menu present the list of attributes to let the user choose the connection he wants to go through.
    image

@nicolas-lambert-tc nicolas-lambert-tc self-assigned this May 2, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented May 2, 2025

Codecov Report

Attention: Patch coverage is 79.59184% with 10 lines in your changes missing coverage. Please review.

Project coverage is 76.84%. Comparing base (006288a) to head (7881fa1).
Report is 42 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
meshroom/core/attribute.py 66.66% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2716      +/-   ##
===========================================
+ Coverage    76.75%   76.84%   +0.09%     
===========================================
  Files           40       41       +1     
  Lines         6082     6132      +50     
===========================================
+ Hits          4668     4712      +44     
- Misses        1414     1420       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nicolas-lambert-tc nicolas-lambert-tc changed the title Feature/attribute navigation [ui] AttributeEditor: Feature/attribute navigation buttons May 2, 2025
@nicolas-lambert-tc nicolas-lambert-tc added UI feature new feature (proposed as PR or issue planned by dev) labels May 2, 2025
@nicolas-lambert-tc nicolas-lambert-tc force-pushed the feature/attribute-navigation branch from c2329fe to 321a52d Compare May 2, 2025 17:26
@nicolas-lambert-tc nicolas-lambert-tc marked this pull request as ready for review May 5, 2025 09:36
Comment thread meshroom/ui/qml/GraphEditor/AttributeItemDelegate.qml Outdated
Comment thread meshroom/ui/qml/GraphEditor/AttributeItemDelegate.qml Outdated
Comment thread meshroom/core/attribute.py
@fabiencastan fabiencastan added this to the Meshroom 2025.1.0 milestone May 6, 2025
@nicolas-lambert-tc nicolas-lambert-tc force-pushed the feature/attribute-navigation branch from 54490db to 05ce140 Compare May 7, 2025 09:01
Comment thread meshroom/core/attribute.py Outdated
Comment thread meshroom/core/attribute.py
Comment thread meshroom/ui/qml/Application.qml Outdated
@nicolas-lambert-tc nicolas-lambert-tc force-pushed the feature/attribute-navigation branch from 05ce140 to 0fbee37 Compare May 13, 2025 07:38
@nicolas-lambert-tc nicolas-lambert-tc force-pushed the feature/attribute-navigation branch from 0fbee37 to 7881fa1 Compare May 13, 2025 12:00
@fabiencastan fabiencastan merged commit 702e78f into develop May 13, 2025
5 checks passed
@fabiencastan fabiencastan deleted the feature/attribute-navigation branch May 13, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature new feature (proposed as PR or issue planned by dev) UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants