Skip to content

[desc] Import CREATE_NEW_PROCESS_GROUP flag from subprocess #2719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fabiencastan merged 1 commit into from
May 5, 2025
Merged

[desc] Import CREATE_NEW_PROCESS_GROUP flag from subprocess #2719

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion meshroom/core/desc/node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,8 @@
# Change the process group to avoid Meshroom main process being killed if the
# subprocess gets terminated by the user or an Out Of Memory (OOM kill).
if sys.platform == "win32":
platformArgs = {"creationflags": psutil.CREATE_NEW_PROCESS_GROUP}
from subprocess import CREATE_NEW_PROCESS_GROUP
platformArgs = {"creationflags": CREATE_NEW_PROCESS_GROUP}

Check warning on line 159 in meshroom/core/desc/node.py

View check run for this annotation

Codecov / codecov/patch

meshroom/core/desc/node.py#L158-L159 

Added lines #L158 - L159 were not covered by tests
# Note: DETACHED_PROCESS means fully detached process.
# We don't want a fully detached process to ensure that if Meshroom is killed,
# the subprocesses are killed too.
Expand Down