Skip to content

[ui] Viewer2D can display the content of tracks files#2720

Merged
cbentejac merged 3 commits intodevelopfrom
dev/tracks
May 20, 2025
Merged

[ui] Viewer2D can display the content of tracks files#2720
cbentejac merged 3 commits intodevelopfrom
dev/tracks

Conversation

@servantftransperfect
Copy link
Copy Markdown
Contributor

@servantftransperfect servantftransperfect commented May 12, 2025

This PR enable the loading and display of tracks in the experimental pipeline (using pre computed json tracks files).

Also add the list of providers in the feature overlay

@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.84%. Comparing base (4f1e003) to head (7d3cf68).
Report is 41 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2720      +/-   ##
===========================================
+ Coverage    76.74%   76.84%   +0.10%     
===========================================
  Files           40       41       +1     
  Lines         6084     6132      +48     
===========================================
+ Hits          4669     4712      +43     
- Misses        1415     1420       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@servantftransperfect servantftransperfect changed the title Enable direct loading of tracks Viewer2D can display the content of tracks files May 16, 2025
Copy link
Copy Markdown
Contributor

@cbentejac cbentejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comments, every seems to be working as expected.

Comment thread meshroom/ui/qml/Viewer/FeaturesInfoOverlay.qml Outdated
Comment thread meshroom/ui/qml/Viewer/FeaturesInfoOverlay.qml Outdated
Comment thread meshroom/ui/qml/Viewer/FeaturesInfoOverlay.qml Outdated
Comment thread meshroom/ui/qml/Viewer/FeaturesInfoOverlay.qml Outdated
Comment thread meshroom/ui/qml/Viewer/Viewer2D.qml Outdated
servantftransperfect and others added 2 commits May 20, 2025 08:28
Co-authored-by: Candice Bentéjac <candice.bentejac@gmail.com>
Co-authored-by: Candice Bentéjac <candice.bentejac@gmail.com>
@cbentejac cbentejac changed the title Viewer2D can display the content of tracks files [ui] Viewer2D can display the content of tracks files May 20, 2025
@cbentejac cbentejac merged commit fb604bb into develop May 20, 2025
5 checks passed
@cbentejac cbentejac deleted the dev/tracks branch May 20, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants