[ui] Homepage: Project can be removed with right click#2724
[ui] Homepage: Project can be removed with right click#2724
Conversation
nicolas-lambert-tc
requested review from
CedricThebault,
cbentejac,
demoulinv,
fabiencastan,
mh0g,
servantftransperfect and
yann-lty
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #2724 +/- ##
========================================
Coverage 76.84% 76.84%
========================================
Files 41 41
Lines 6132 6132
========================================
Hits 4712 4712
Misses 1420 1420 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nicolas-lambert-tc
added
feature
cbentejac
left a comment
cbentejac
left a comment
There was a problem hiding this comment.
The "Projects..." action is not necessary as we have the "Home" icon next to the "File" menu, so that part from the second commit can be dropped.
I also don't think there's a need to make a distinction between the simple and the double click: if the user left-clicks (once) on a projet, we should try to open it as is currently the case; if the user right-clicks, then the context menu should be opened, with the "Open" and "Delete" options.
nicolas-lambert-tc
force-pushed
the
feature/project-remove
branch
from
081d5c8 to
fffeb8d
Compare
cbentejac
left a comment
cbentejac
left a comment
There was a problem hiding this comment.
Functionally speaking, I think we're good to go!
| running: gridView.visible && modelData["thumbnail"] && thumbnail.status != Image.Ready | ||
| visible: running | ||
| } | ||
| } |
| function setCurrentTab(tabName) { | ||
| const tabIndex = tabPanel.tabs.indexOf(tabName) | ||
|
|
||
| if (tabIndex) { | ||
| tabPanel.currentTab = tabIndex | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Is this function still necessary with the recent changes? I don't see it used anywhere.
There was a problem hiding this comment.
Thx, you're right, it's an oversight.
nicolas-lambert-tc
force-pushed
the
feature/project-remove
branch
from
fffeb8d to
297594e
Compare
…t Projects menu item.
nicolas-lambert-tc
force-pushed
the
feature/project-remove
branch
from
297594e to
d5bcada
Compare
cbentejac
changed the title
2 participants
Description
Add a context menu on the project to allow the deletion of a specific project
Features list