bugfix ExecMode status#2737
Merged
fabiencastan merged 1 commit intodevelopfrom Jun 5, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #2737 +/- ##
========================================
Coverage 77.14% 77.14%
========================================
Files 41 41
Lines 6164 6165 +1
========================================
+ Hits 4755 4756 +1
Misses 1409 1409 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
demoulinv
force-pushed
the
bugfix/execModeStatus
branch
from
8e03f30 to
77cb06f
Compare
fabiencastan
approved these changes
Jun 4, 2025
fabiencastan
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows to stop the computation of a pure python node when processing locally. Before, the ExecMode status was reset to NONE when starting the computation in the subprocess. ExecMode is not a dynamic value, it has been removed from the resetDynamicValues method and set only at initialization.