Skip to content

[ui] Reconstruction: Fix setup of temporary CameraInit nodes#2762

Merged
fabiencastan merged 1 commit intodevelopfrom
fix/tempCameraInit
Jun 26, 2025
Merged

[ui] Reconstruction: Fix setup of temporary CameraInit nodes#2762
fabiencastan merged 1 commit intodevelopfrom
fix/tempCameraInit

Conversation

@cbentejac
Copy link
Copy Markdown
Contributor

Description

This PR fixes a bug introduced by #2733 which caused the setup of temporary CameraInit nodes to fail, as we were attempting to call a method from an object that had not been instantiated yet.

Temporary CameraInit nodes are used, among other things, to display the results of the LdrToHdrMerge node in the "Hdr Fusion" pipeline.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.80%. Comparing base (517a64d) to head (733f029).
Report is 2 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2762   +/-   ##
========================================
  Coverage    77.80%   77.80%           
========================================
  Files           48       48           
  Lines         6674     6674           
========================================
  Hits          5193     5193           
  Misses        1481     1481           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fabiencastan fabiencastan merged commit 9a7cd2d into develop Jun 26, 2025
5 checks passed
@fabiencastan fabiencastan deleted the fix/tempCameraInit branch June 26, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants