[ui] Reconstruction: Fix setup of temporary CameraInit nodes#2762
Merged
fabiencastan merged 1 commit intodevelopfrom Jun 26, 2025
Merged
[ui] Reconstruction: Fix setup of temporary CameraInit nodes#2762fabiencastan merged 1 commit intodevelopfrom
CameraInit nodes#2762fabiencastan merged 1 commit intodevelopfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #2762 +/- ##
========================================
Coverage 77.80% 77.80%
========================================
Files 48 48
Lines 6674 6674
========================================
Hits 5193 5193
Misses 1481 1481 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fabiencastan
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug introduced by #2733 which caused the setup of temporary
CameraInitnodes to fail, as we were attempting to call a method from an object that had not been instantiated yet.Temporary
CameraInitnodes are used, among other things, to display the results of theLdrToHdrMergenode in the "Hdr Fusion" pipeline.