Skip to content

Conversation

@cbentejac
Copy link
Contributor

Description

This PR updates resolveRezSubrequires to append the current plugin's package (with its version) to the packages list when it matches the plugin's URI, ensuring it is included in the resolved dependencies.

It ensures that the plugin's nodes will be correctly recognized when processing the meshroom_compute operations.

…ages

This allows for the plugin's nodes to be correctly recognized and
executed when launching the `meshroom_compute` operations.
@cbentejac cbentejac added this to the Meshroom 2025.1.0 milestone Aug 13, 2025
@cbentejac cbentejac requested a review from fabiencastan August 13, 2025 10:13
@cbentejac cbentejac self-assigned this Aug 13, 2025
@codecov
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.43%. Comparing base (0362aab) to head (b643c88).
⚠️ Report is 19 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
meshroom/core/plugins.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2801      +/-   ##
===========================================
- Coverage    77.46%   77.43%   -0.03%     
===========================================
  Files           48       48              
  Lines         6735     6737       +2     
===========================================
  Hits          5217     5217              
- Misses        1518     1520       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cbentejac cbentejac marked this pull request as draft August 18, 2025 14:00
@cbentejac cbentejac closed this Sep 1, 2025
@cbentejac cbentejac deleted the fix/rezResolve branch September 1, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants