Skip to content

Fix menu toggle behavior for gear icon buttons across UI components #2833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Fix menu toggle behavior for gear icon buttons across UI components #2833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a94eeb
Initial plan
Copilot Aug 17, 2025
b53d03a
Fix sequence player and image viewer menu toggle behavior
Copilot Aug 17, 2025
436f585
Fix additional menu toggle issues across the UI
Copilot Aug 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion meshroom/ui/qml/Application.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1184,7 +1184,7 @@ Page {
text: MaterialIcons.more_vert
font.pointSize: 11
padding: 2
onClicked: graphEditorMenu.open()
onClicked: graphEditorMenu.visible ? graphEditorMenu.close() : graphEditorMenu.open()
checkable: true
checked: graphEditorMenu.visible
Menu {
Expand Down
2 changes: 1 addition & 1 deletion meshroom/ui/qml/GraphEditor/NodeEditor.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ Panel {
text: MaterialIcons.more_vert
font.pointSize: 11
padding: 2
onClicked: settingsMenu.open()
onClicked: settingsMenu.visible ? settingsMenu.close() : settingsMenu.open()
checkable: true
checked: settingsMenu.visible
Menu {
Expand Down
2 changes: 1 addition & 1 deletion meshroom/ui/qml/ImageGallery/ImageGallery.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ Panel {
padding: 2
checkable: true
checked: galleryMenu.visible
onClicked: galleryMenu.open()
onClicked: galleryMenu.visible ? galleryMenu.close() : galleryMenu.open()
Menu {
id: galleryMenu
y: parent.height
Expand Down
2 changes: 1 addition & 1 deletion meshroom/ui/qml/Viewer/SequencePlayer.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ FloatingPane {
text: MaterialIcons.settings
font.pointSize: 11
padding: 2
onClicked: infoMenu.open()
onClicked: infoMenu.visible ? infoMenu.close() : infoMenu.open()
checkable: true
checked: infoMenu.visible

Expand Down
2 changes: 1 addition & 1 deletion meshroom/ui/qml/WorkspaceView.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ Item {
padding: 2
checkable: true
checked: imageViewerMenu.visible
onClicked: imageViewerMenu.open()
onClicked: imageViewerMenu.visible ? imageViewerMenu.close() : imageViewerMenu.open()
Menu {
id: imageViewerMenu
y: parent.height
Expand Down