Skip to content

Conversation

@demoulinv
Copy link
Contributor

Description

This PR is a bugfix to support graph names with spaces when computing a meshroom graph containing some plugins. Plugin computation is launched using meshroom_compute and double quote are needed around the graph name parameter.

cf issue: #2808

Features list

Implementation remarks

@demoulinv demoulinv added this to the Meshroom 2025.1.0 milestone Aug 19, 2025
@codecov
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 77.46%. Comparing base (0362aab) to head (da05aae).
⚠️ Report is 21 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
meshroom/core/desc/node.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2838   +/-   ##
========================================
  Coverage    77.46%   77.46%           
========================================
  Files           48       48           
  Lines         6735     6735           
========================================
  Hits          5217     5217           
  Misses        1518     1518           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cbentejac cbentejac changed the title Support graph names with spaces [core] Support graph names with spaces Sep 1, 2025
@cbentejac cbentejac merged commit ccf2993 into develop Sep 1, 2025
4 of 5 checks passed
@cbentejac cbentejac deleted the bugfix/graphNamingWithSpace branch September 1, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] ImageDetectionPrompt: Spaces in input path not recognized

4 participants