-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[desc] Add node process function to use on single-chunk nodes #2847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2847 +/- ##
===========================================
+ Coverage 79.00% 79.08% +0.07%
===========================================
Files 51 51
Lines 6858 6889 +31
===========================================
+ Hits 5418 5448 +30
- Misses 1440 1441 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8d939a7 to
9c4f6b2
Compare
|
|
||
|
|
||
| class TestNodeA(desc.BaseNode): | ||
| __test__ = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: without the __test__ = False line, pytest tries to load the TestNodeA and TestNodeB classes because of the "Test" in their name, and fails as they have __init__ methods.
An alternative to using __test__ = False would be to rename the classes to not use the word "Test".
cbentejac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but waiting for #2845 to be merged first.
7080dde to
7e56aa0
Compare
7e56aa0 to
4603513
Compare
4603513 to
1be1fc5
Compare
Warning
It would be better to merge this PR after #2845 because the logger is not available in
processfor now (as it's provided bychunk). This PR mentioned fixes this by setupingloggingso that we can use it directlyDescription
processfunctionprocessChunkhas not been overrided, thenprocesswill be calledExamples
Because we don't have access to the chunk we can't use
chunk.loggerHowever, after #2845 this won't be an issue because we could use logging normally :
