Skip to content

[core] desc.node: Support the use of custom Python executables for meshroom_compute #2849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2025
Merged

[core] desc.node: Support the use of custom Python executables for meshroom_compute #2849

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8366a38
[core] desc.node: Add a `pythonExecutable` member to the `Node` class
cbentejac Aug 21, 2025
011cc0c
[core] desc.node: Use node's Python executable to call `meshroom_comp…
cbentejac Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions meshroom/core/desc/node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@

_MESHROOM_ROOT = Path(meshroom.__file__).parent.parent.as_posix()
_MESHROOM_COMPUTE = (Path(_MESHROOM_ROOT) / "bin" / "meshroom_compute").as_posix()
_MESHROOM_COMPUTE_EXE = f"python {_MESHROOM_COMPUTE}"


class MrNodeType(enum.Enum):
Expand Down Expand Up @@ -263,6 +262,7 @@ def processChunk(self, chunk):


class Node(BaseNode):
pythonExecutable = "python"

def __init__(self):
super(Node, self).__init__()
Expand All @@ -271,15 +271,18 @@ def getMrNodeType(self):
return MrNodeType.NODE

def processChunkInEnvironment(self, chunk):
meshroomComputeCmd = f"{_MESHROOM_COMPUTE_EXE} \"{chunk.node.graph.filepath}\" --node {chunk.node.name} --extern --inCurrentEnv"
meshroomComputeCmd = f"{chunk.node.nodeDesc.pythonExecutable} {_MESHROOM_COMPUTE}" + \
f" \"{chunk.node.graph.filepath}\" --node {chunk.node.name}" + \
" --extern --inCurrentEnv"

if len(chunk.node.getChunks()) > 1:
meshroomComputeCmd += f" --iteration {chunk.range.iteration}"

runtimeEnv = chunk.node.nodeDesc.plugin.runtimeEnv
cmdPrefix = chunk.node.nodeDesc.plugin.commandPrefix
cmdSuffix = chunk.node.nodeDesc.plugin.commandSuffix
self.executeChunkCommandLine(chunk, cmdPrefix + meshroomComputeCmd + cmdSuffix, env=runtimeEnv)
self.executeChunkCommandLine(chunk, cmdPrefix + meshroomComputeCmd + cmdSuffix,
env=runtimeEnv)


class CommandLineNode(BaseNode):
Expand Down
Loading