-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[ui] Implement status bar to display messages #2861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2861 +/- ##
========================================
Coverage 79.08% 79.08%
========================================
Files 51 51
Lines 6889 6889
========================================
Hits 5448 5448
Misses 1441 1441 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a39eaf0 to
205efe5
Compare
8cb8722 to
316e86a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a status bar component for the Meshroom UI to display informational messages with different status levels (default, ok, warning, error). The status bar appears in the bottom toolbar and provides visual feedback for operations like plugin reloading.
Key changes:
- Create a new
StatusBarQML component with message display and status icons - Integrate the status bar into the main application footer
- Add Python-side message handling through the app interface
- Implement asynchronous plugin reloading with status notifications
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| meshroom/ui/qml/Controls/StatusBar.qml | New status bar component with message display and timer functionality |
| meshroom/ui/qml/Controls/qmldir | Register the new StatusBar component |
| meshroom/ui/qml/Application.qml | Integrate status bar into footer and update plugin reload action |
| meshroom/ui/app.py | Add showMessage method and forceUIUpdate for Python-side message handling |
| meshroom/ui/reconstruction.py | Implement asynchronous plugin reloading with status notifications |
| meshroom/core/node.py | Minor whitespace addition |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
b69c0cf to
e8d14f1
Compare
9c09625 to
194275c
Compare
…ar + minor adjustments on the UI
194275c to
fe4fe0c
Compare
Description
StatusBarQML element to display messagesshowMessage(message, status, duration)funciton is used to change the icon/text for a specific duration (5 seconds by default)StatusBaron Meshroom footer ToolBarreconstrucitonto make sure the UI is not blocked when plugins are reloadedExample