-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[nodes] Rename the Publish node to CopyFiles
#2868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2868 +/- ##
========================================
Coverage 79.08% 79.08%
========================================
Files 51 51
Lines 6889 6889
========================================
Hits 5448 5448
Misses 1441 1441 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
13bb647 to
649cdb5
Compare
Alxiice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with the PR I'm just wondering if that would be better to keep the publish node with a depreciation warning for now but that's probably not really necessary
fabiencastan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to name it "CopyFiles".
We already have many Export nodes to export in a different file formats.
e3d1c32 to
1efc8e0
Compare
Publish node to ExportFilesPublish node to CopyFiles
1efc8e0 to
ed99822
Compare
Description
This PR renames the
Publishnode, whose name may be ambiguous depending on the context, toCopyFiles.This should preferably be merged after #2867 as it contains changes that are based on the
Publishnode.Note
The following PRs should be merged along with this one:
Publishnodes toCopyFilesin all templates AliceVision#1962Publishnode toCopyFilesmeshroomHub/mrSegmentation#29