Skip to content

Conversation

@cbentejac
Copy link
Contributor

@cbentejac cbentejac commented Aug 29, 2025

Description

This PR renames the Publish node, whose name may be ambiguous depending on the context, to CopyFiles.

This should preferably be merged after #2867 as it contains changes that are based on the Publish node.

@codecov
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

❌ Patch coverage is 46.66667% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.08%. Comparing base (c2f3115) to head (ed99822).
⚠️ Report is 10 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
meshroom/nodes/general/CopyFiles.py 33.33% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2868   +/-   ##
========================================
  Coverage    79.08%   79.08%           
========================================
  Files           51       51           
  Lines         6889     6889           
========================================
  Hits          5448     5448           
  Misses        1441     1441           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@Alxiice Alxiice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with the PR I'm just wondering if that would be better to keep the publish node with a depreciation warning for now but that's probably not really necessary

Copy link
Member

@fabiencastan fabiencastan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to name it "CopyFiles".
We already have many Export nodes to export in a different file formats.

@cbentejac cbentejac force-pushed the dev/renamePublish branch 2 times, most recently from e3d1c32 to 1efc8e0 Compare September 17, 2025 08:37
@cbentejac cbentejac changed the title [nodes] Rename the Publish node to ExportFiles [nodes] Rename the Publish node to CopyFiles Sep 17, 2025
@fabiencastan fabiencastan merged commit da1a5e4 into develop Sep 18, 2025
4 of 5 checks passed
@fabiencastan fabiencastan deleted the dev/renamePublish branch September 18, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants