[Controls] Horizontally center the Color Selector with respect to the tool button #2871
Conversation
The Color Selector pop-up was placed on the left of the tool button, which was causing a part of it to potentially be partially out of screen. It is now horizontally centered on the tool button, which prevents it from being clipped while being visually relevant.
cbentejac
requested review from
Alxiice,
CedricThebault,
Copilot,
fabiencastan and
servantftransperfect
There was a problem hiding this comment.
Pull Request Overview
This pull request centers the Color Selector popup horizontally with respect to its trigger button to prevent clipping issues. The change improves the UI positioning by ensuring the popup appears centered rather than aligned to the left edge of the button.
- Updated the horizontal positioning calculation to center the popup
- Fixed a spelling error in a comment
- Updated another comment for clarity
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| ] | ||
|
|
||
| // When a color gets selected/choosen | ||
| // When a color gets selected/chosen |
There was a problem hiding this comment.
Good fix - corrected the spelling from 'choosen' to 'chosen'.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2871 +/- ##
========================================
Coverage 77.46% 77.46%
========================================
Files 48 48
Lines 6735 6735
========================================
Hits 5217 5217
Misses 1518 1518 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This pull request makes minor improvements to the
ColorSelector.qmlfile, ensuring that the Color Selector pop-up is now horizontally centered with respect to the tool button that makes it appear/disappear. It previously was placed on its left, potentially causing it to be clipped out.Previous position of the Color Selector
New position of the Color Selector
This fixes #2814.