Skip to content

Conversation

@gregoire-dl
Copy link
Member

Description

Refactored core.Attribute for improved clarity, consistency, and maintainability.

Features list

  • Rename variable and methods for better understanding.
  • Remove unused methods / properties / signals.
  • Avoid double usage of properties and methods.
  • More consistency for link-related properties.
  • Add documentation.

@gregoire-dl gregoire-dl added this to the Meshroom 2026.1.0 milestone Sep 2, 2025
@gregoire-dl gregoire-dl self-assigned this Sep 2, 2025
@gregoire-dl gregoire-dl added type:enhancement type:pr pull request issue labels Sep 2, 2025
@codecov
Copy link

codecov bot commented Sep 2, 2025

Codecov Report

❌ Patch coverage is 86.10354% with 51 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.59%. Comparing base (5dda2ac) to head (9760d65).
⚠️ Report is 60 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
meshroom/core/attribute.py 85.29% 45 Missing ⚠️
meshroom/core/graph.py 70.00% 3 Missing ⚠️
meshroom/core/desc/computation.py 0.00% 2 Missing ⚠️
meshroom/core/node.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2872      +/-   ##
===========================================
+ Coverage    77.46%   77.59%   +0.13%     
===========================================
  Files           48       48              
  Lines         6735     6655      -80     
===========================================
- Hits          5217     5164      -53     
+ Misses        1518     1491      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cbentejac cbentejac merged commit de33f55 into develop Sep 8, 2025
5 checks passed
@cbentejac cbentejac deleted the dev/attributeRefactoring branch September 8, 2025 15:16
fabiencastan added a commit to meshroomHub/mrSegmentation that referenced this pull request Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:enhancement type:pr pull request issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants