-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[submitter] Add tractor API #2874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (14.28%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #2874 +/- ##
===========================================
- Coverage 79.54% 79.41% -0.13%
===========================================
Files 51 51
Lines 6975 6987 +12
===========================================
+ Hits 5548 5549 +1
- Misses 1427 1438 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Alxiice would you be so kind to document how to setup Meshroom with tractor? https://github.com/alicevision/Meshroom/wiki/Renderfarm-submitters Thank you! |
hello @natowi it's a bit difficult to explain exactly how to test tractor because it relies on code from Pixar that I cannot really share here. However if that helps I added some documentation on the wiki and explained a bit more how the submitter works and how to create one |
4178a29 to
63d7b3f
Compare
fe92617 to
f03af18
Compare
cbentejac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tractorConfig.json is missing and needs to be added, otherwise the submitter for Tractor cannot be loaded.
Submissions work fine, but we need to handle the case where there's no default submitter through the MESHROOM_DEFAULT_SUBMITTER environment variable if there are submitters that have been successfully loaded.
9c245d8 to
97af674
Compare
I replaced |
ab0124a to
56221dc
Compare
…from config (tag for london machines)
56221dc to
46f991f
Compare
Description
Note
The code is ready for review but I'm still adding test and documentation
submiton nodes whose name was not super clearmeshroom/submitters)tractorSubmitter.pywith the tractor submitterInformation for review
Important
Another important modification was done on the task ordering, as you can see with the simpleFarm currently when we select multiple tasks and submit, tasks are duplicated

With the current submitter, CameraInit is submitted on its own AND a second time as a child of SleepNode
Using the new API we make sure to only add tasks once to the job
However it's clear that it's an error that happens somewhere else on the code because we should have a clean graph that is submitted in the first place, and I will create another PR to resolve this issue
How to test
Launch a job with SimpleFarm submitter, then with Tractor submitter, compare both jobs created on tractor