Skip to content

Conversation

@Alxiice
Copy link
Contributor

@Alxiice Alxiice commented Sep 11, 2025

Description

Add NodeActions

  • Creates a header on top of the nodes with buttons to launch / force relaunch / submit the node
  • The NodeActions follows the node but keeps a uniform scale

Demonstration on how the items process work
Peek 2025-09-30 15-37

Note

Small remark : selectNodeByIndex triggers onSelectedNodeDelegateChanged twice...

@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.41%. Comparing base (aabe589) to head (82c17f2).
⚠️ Report is 16 commits behind head on develop.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2884   +/-   ##
========================================
  Coverage    79.41%   79.41%           
========================================
  Files           51       51           
  Lines         6987     6987           
========================================
  Hits          5549     5549           
  Misses        1438     1438           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Alxiice Alxiice force-pushed the dev/node_actions branch 2 times, most recently from 19089b6 to 976bc4a Compare September 16, 2025 13:25
@Alxiice Alxiice self-assigned this Sep 16, 2025
@Alxiice Alxiice added this to the Meshroom 2026.1.0 milestone Sep 17, 2025
@Alxiice Alxiice added feature new feature (proposed as PR or issue planned by dev) UI labels Sep 17, 2025
@fabiencastan
Copy link
Member

We should have either 'Compute' or 'Recompute', but not both at the same time.

@Alxiice Alxiice force-pushed the dev/node_actions branch 2 times, most recently from b264f05 to 739872b Compare September 30, 2025 10:43
@Alxiice Alxiice requested a review from fabiencastan October 1, 2025 10:28
@fabiencastan fabiencastan changed the title [ui] Add NodeActions qml element to re-launch computation [ui] Add NodeActions to launch computation Oct 1, 2025
@fabiencastan fabiencastan merged commit 1b2d5e2 into develop Oct 1, 2025
4 checks passed
@fabiencastan fabiencastan deleted the dev/node_actions branch October 1, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature new feature (proposed as PR or issue planned by dev) UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants