Skip to content

Conversation

@Alxiice
Copy link
Contributor

@Alxiice Alxiice commented Sep 12, 2025

Description

Fix issue with IntParam/FloatParam value validation
In #2836 we introduced a system to evaluate expressions in int/float fields, however the way it was implemented broke the value validation on attributes on the python side.
With this PR the issue is solved however we loose undostack on wrong expressions

@codecov
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.02%. Comparing base (26f62b6) to head (afe02f3).
⚠️ Report is 3 commits behind head on develop.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2885   +/-   ##
========================================
  Coverage    79.02%   79.02%           
========================================
  Files           51       51           
  Lines         6856     6856           
========================================
  Hits          5418     5418           
  Misses        1438     1438           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Alxiice Alxiice requested a review from cbentejac September 12, 2025 09:57
@cbentejac cbentejac added this to the Meshroom 2026.1.0 milestone Sep 12, 2025
@cbentejac cbentejac changed the title Bugfix/expression text fields string error Fix Int/Float attributes' validation on values for expressions Sep 12, 2025
@cbentejac cbentejac changed the title Fix Int/Float attributes' validation on values for expressions Fix the value validation for Int/Float attributes with expressions Sep 12, 2025
@cbentejac cbentejac merged commit 0e46cbe into develop Sep 12, 2025
5 checks passed
@cbentejac cbentejac deleted the bugfix/expression_text_fields_string_error branch September 12, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants