Skip to content

Conversation

@fabiencastan
Copy link
Member

No description provided.

@fabiencastan fabiencastan added this to the Meshroom 2026.1.0 milestone Sep 19, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where node size updates were not being applied to InputNode types by refactoring the size computation logic from the _updateChunks method to a new dedicated _updateNodeSize method that is called for all node types.

  • Extracted node size computation from _updateChunks into a new _updateNodeSize method
  • Added _updateNodeSize call to updateInternals to ensure all nodes get proper size updates
  • Added override in CompatibilityNode to prevent size recomputation for compatibility nodes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.09%. Comparing base (fcfa146) to head (2c09df8).
⚠️ Report is 13 commits behind head on develop.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2895      +/-   ##
===========================================
+ Coverage    79.08%   79.09%   +0.01%     
===========================================
  Files           51       51              
  Lines         6889     6893       +4     
===========================================
+ Hits          5448     5452       +4     
  Misses        1441     1441              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fabiencastan fabiencastan marked this pull request as ready for review September 19, 2025 15:16
@cbentejac cbentejac merged commit 772ed15 into develop Sep 20, 2025
5 checks passed
@cbentejac cbentejac deleted the dev/inputNodeSize branch September 20, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants