Skip to content

Conversation

@cbentejac
Copy link
Contributor

@cbentejac cbentejac commented Sep 20, 2025

Description

This PR introduces a mechanism to ensure that required dependencies for meshroom_compute, specifically psutil, are always included in the node execution environment for rez plugins. Dependencies for meshroom_compute are added to the environment without specifying any version or attempting to match Meshroom's, in order for it to be set directly during the environment resolution.

Dependency management improvements:

  • Introduced a new constant _MESHROOM_COMPUTE_DEPS in meshroom/core/desc/node.py to define required dependencies for meshroom_compute.
  • Updated meshroom/core/plugins.py to import _MESHROOM_COMPUTE_DEPS and ensure all dependencies listed in it (currently psutil) are always included in the resolved execution environment for plugins, unless already present [1] [2].

@cbentejac cbentejac added this to the Meshroom 2026.1.0 milestone Sep 20, 2025
@cbentejac cbentejac self-assigned this Sep 20, 2025
@codecov
Copy link

codecov bot commented Sep 20, 2025

Codecov Report

❌ Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.56%. Comparing base (e9e637d) to head (9b94471).
⚠️ Report is 3 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
meshroom/core/plugins.py 14.28% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2898      +/-   ##
===========================================
- Coverage    79.62%   79.56%   -0.07%     
===========================================
  Files           51       51              
  Lines         6970     6977       +7     
===========================================
+ Hits          5550     5551       +1     
- Misses        1420     1426       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

cbentejac and others added 2 commits September 20, 2025 22:26
…esent

`psutil` is a dependency of `meshroom_compute`, which cannot run if it
is not part of the environment. For rez plugins, if `psutil` is not
already part of the plugin's environment, it is added. No version is
specified so it can be resolved in the environment, without being aligned
on Meshroom's.
@fabiencastan fabiencastan merged commit 391afc7 into develop Sep 20, 2025
3 of 5 checks passed
@fabiencastan fabiencastan deleted the dev/psutilDep branch September 20, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants