-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[core] Correctly set _sourceCodeFolder in BaseNode's constructor
#2910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2910 +/- ##
===========================================
+ Coverage 80.61% 80.86% +0.24%
===========================================
Files 55 57 +2
Lines 7692 7792 +100
===========================================
+ Hits 6201 6301 +100
Misses 1491 1491 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fabiencastan
reviewed
Oct 8, 2025
fabiencastan
reviewed
Oct 8, 2025
9eaec91 to
ba51951
Compare
nodeSourceCodeFolder static variable once available_sourceCodeFolder in BaseNode's constructor
fabiencastan
approved these changes
Oct 16, 2025
ba51951 to
e8ae796
Compare
fabiencastan
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a regression introduced by the refactoring of the command line variables in #2888, where the static
nodeSourceCodeFolderis initialized but never set with the correct value once it becomes available.This is fixed by initializing
_sourceCodeFolderdirectly in theBaseNode's constructor if the description is available (if it isn't, the node will be inUnknown Nodecompatibility error anyway). This both simplifies what was done prior to #2888 (where_sourceCodeFolderwas correctly set later than it should have been) and ensures that_staticExpVars["nodeSourceCodeFolder"]is initialized with the correct value as well.Additionally, simple unit tests are added to ensure that static variables are always correctly set. A test
InputNodeis also added to one of the test plugins to cover all cases.