Skip to content

Conversation

@cbentejac
Copy link
Contributor

@cbentejac cbentejac commented Oct 7, 2025

Description

This PR fixes a regression introduced by the refactoring of the command line variables in #2888, where the static nodeSourceCodeFolder is initialized but never set with the correct value once it becomes available.

This is fixed by initializing _sourceCodeFolder directly in the BaseNode's constructor if the description is available (if it isn't, the node will be in Unknown Node compatibility error anyway). This both simplifies what was done prior to #2888 (where _sourceCodeFolder was correctly set later than it should have been) and ensures that _staticExpVars["nodeSourceCodeFolder"] is initialized with the correct value as well.

Additionally, simple unit tests are added to ensure that static variables are always correctly set. A test InputNode is also added to one of the test plugins to cover all cases.

@cbentejac cbentejac added this to the Meshroom 2026.1.0 milestone Oct 7, 2025
@cbentejac cbentejac self-assigned this Oct 7, 2025
@cbentejac cbentejac marked this pull request as ready for review October 7, 2025 14:45
@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.86%. Comparing base (e88f34a) to head (e8ae796).
⚠️ Report is 36 commits behind head on develop.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2910      +/-   ##
===========================================
+ Coverage    80.61%   80.86%   +0.24%     
===========================================
  Files           55       57       +2     
  Lines         7692     7792     +100     
===========================================
+ Hits          6201     6301     +100     
  Misses        1491     1491              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cbentejac cbentejac force-pushed the fix/nodeSourceCodeFolder branch from 9eaec91 to ba51951 Compare October 9, 2025 10:22
@cbentejac cbentejac changed the title [core] Correctly set nodeSourceCodeFolder static variable once available [core] Correctly set _sourceCodeFolder in BaseNode's constructor Oct 9, 2025
@cbentejac cbentejac force-pushed the fix/nodeSourceCodeFolder branch from ba51951 to e8ae796 Compare October 17, 2025 15:22
@fabiencastan fabiencastan merged commit 4ad6b83 into develop Oct 17, 2025
4 checks passed
@fabiencastan fabiencastan deleted the fix/nodeSourceCodeFolder branch October 17, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants