Skip to content

Conversation

@servantftransperfect
Copy link
Contributor

@servantftransperfect servantftransperfect commented Oct 15, 2025

This pull request extends the application's support for the RomaReducer node, ensuring it is recognized as a provider of features and matches folders in both the backend and the UI. The changes update relevant logic to include RomaReducer alongside existing node types, improving consistency and functionality when handling feature and match data.

Related AliceVision PR: alicevision/AliceVision#1922

Backend and UI support for RomaReducer:

  • Added RomaReducer to the featureProvider and matchProvider node type lists, so it is now treated as a valid source of features and matches folders in the reconstruction pipeline (meshroom/ui/reconstruction.py).

UI logic for features folders:

  • Updated the logic in Viewer2D.qml to recognize RomaReducer as a node type that provides a features folder, ensuring its output is included in the results shown in the UI (meshroom/ui/qml/Viewer/Viewer2D.qml).

@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.74%. Comparing base (f939161) to head (0e42f8e).
⚠️ Report is 13 commits behind head on develop.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2922   +/-   ##
========================================
  Coverage    80.74%   80.74%           
========================================
  Files           55       55           
  Lines         7728     7728           
========================================
  Hits          6240     6240           
  Misses        1488     1488           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cbentejac cbentejac changed the title Add display for ROMA matcher [ui] Add display for ROMA matcher Oct 17, 2025
@cbentejac cbentejac merged commit 76dbf55 into develop Oct 17, 2025
4 checks passed
@cbentejac cbentejac deleted the dev/geometricFiltering branch October 17, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants