Skip to content

Conversation

@nicolas-lambert-tc
Copy link
Contributor

Description

A signal is missing on attribute, to notify the parent's node that an expression has been applied.
You can test it by adds a convertMesh node into any graph. It should have an eye visible.

fix

Implementation remarks

This PR add this signal expressionApplied ans emit it just after an expression has been applied on the attribute.
The node eye visiblity was listening to the outputAttrEnabledChanged.
It has been renamed to in this PR in order to outputAttrChanged because now it reacts to the expressionApplied and the attributeEnabled signals.

Features list

  • Fix Node-eye not visible even if an output 3d file exists in the node.

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.87%. Comparing base (cff6ac5) to head (f766b31).
⚠️ Report is 6 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
meshroom/core/node.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2929   +/-   ##
========================================
  Coverage    80.86%   80.87%           
========================================
  Files           57       57           
  Lines         7792     7796    +4     
========================================
+ Hits          6301     6305    +4     
  Misses        1491     1491           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nicolas-lambert-tc nicolas-lambert-tc force-pushed the fix/node-eye-not-displayed-with-an-expression-on-3d-attribute branch from f24c5df to f766b31 Compare October 28, 2025 16:27
@cbentejac cbentejac merged commit 574538e into develop Oct 30, 2025
4 checks passed
@cbentejac cbentejac deleted the fix/node-eye-not-displayed-with-an-expression-on-3d-attribute branch October 30, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants