Skip to content

Conversation

@cbentejac
Copy link
Contributor

@cbentejac cbentejac commented Nov 25, 2025

Description

This PR applies some linting on the project. It mostly addresses the following suggestions:

  • removing trailing and unneeded whitespaces
  • applying the correct order for module imports
  • generalizing the use of f-strings

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 61.84971% with 66 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.85%. Comparing base (69b518c) to head (705e7f0).
⚠️ Report is 15 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
meshroom/core/stats.py 29.62% 19 Missing ⚠️
meshroom/core/node.py 12.50% 14 Missing ⚠️
meshroom/core/desc/attribute.py 41.17% 10 Missing ⚠️
meshroom/core/attribute.py 57.89% 8 Missing ⚠️
meshroom/core/__init__.py 14.28% 6 Missing ⚠️
meshroom/core/graph.py 14.28% 6 Missing ⚠️
meshroom/core/plugins.py 0.00% 2 Missing ⚠️
meshroom/__init__.py 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (61.84%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2943      +/-   ##
===========================================
- Coverage    80.86%   80.85%   -0.02%     
===========================================
  Files           59       59              
  Lines         7860     7860              
===========================================
- Hits          6356     6355       -1     
- Misses        1504     1505       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@servantftransperfect servantftransperfect merged commit 4e9ff62 into develop Nov 26, 2025
3 of 4 checks passed
@servantftransperfect servantftransperfect deleted the dev/linting branch November 26, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants