Skip to content

Conversation

@Alxiice
Copy link
Contributor

@Alxiice Alxiice commented Dec 4, 2025

Description of the problem

We had several issues on the logs :

  1. first when we had a raise ValueError(...) for example in the processChunk then on the log we only had the error and not the full log
  2. also there was sometimes logs being overwritten and thus missing in the log file
  3. there was additional log files (in addition to 0.log) in parallelized nodes with 1 chunk
  4. finally sometimes we had this kind of thing appearing in the log :
image

Why we had the issues and how this PR addresses them

  • for (1) the reason is that the log file was opened in write mode and therefore changing it to append on executeChunkCommandLine fixes it
  • for (2) the main reason is that we were systematically clearing the file when we call chunk.logManager.start
  • for (3) I made sure we never use log. Even on cases where we have a single chunk I think it's simply better to use 0.log that way we have a better naming consistency anyways.
  • for (4) I don't have a defenitive explanation but the logs were written in binary mode and for some reason the QML part was adding some unknown characters while writing thee log on the log tab. Changing the file opening mode to append is what fixed the issue

@Alxiice Alxiice self-assigned this Dec 4, 2025
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.80%. Comparing base (6d03825) to head (b7ad79d).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
meshroom/core/desc/node.py 0.00% 1 Missing ⚠️
meshroom/core/node.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2946      +/-   ##
===========================================
- Coverage    80.82%   80.80%   -0.02%     
===========================================
  Files           59       59              
  Lines         7844     7842       -2     
===========================================
- Hits          6340     6337       -3     
- Misses        1504     1505       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Alxiice Alxiice added this to the Meshroom 2026.1.0 milestone Dec 4, 2025
@Alxiice Alxiice requested a review from cbentejac December 4, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants