Skip to content

[ui] Use dedicated color for "fatal" and "critical" logs #2948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[ui] Use dedicated color for "fatal" and "critical" logs #2948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbba4ce
[Utils] Add crimson and firebrick colors
cbentejac Sep 3, 2025
acb88ff
[Controls] Apply color to fatal/critical logs
cbentejac Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion meshroom/ui/qml/Controls/TextFileViewer.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,8 +285,10 @@ Item {
// Color line according to log level
if (text.indexOf("[warning]") >= 0)
return Colors.orange
else if(text.indexOf("[error]") >= 0)
else if (text.indexOf("[error]") >= 0)
return Colors.red
else if (text.indexOf("[fatal]") >= 0 || text.indexOf("[critical]") >= 0)
return Colors.firebrick
return palette.text
}
}
Expand Down
2 changes: 2 additions & 0 deletions meshroom/ui/qml/Utils/Colors.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ QtObject {
readonly property color orange: "#FF9800"
readonly property color yellow: "#FFEB3B"
readonly property color red: "#F44336"
readonly property color crimson: "#DC143C"
readonly property color firebrick: "#B22222"
readonly property color blue: "#03A9F4"
readonly property color cyan: "#00BCD4"
readonly property color pink: "#E91E63"
Expand Down