Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2967 +/- ##
===========================================
- Coverage 80.76% 80.74% -0.02%
===========================================
Files 59 59
Lines 7849 7853 +4
===========================================
+ Hits 6339 6341 +2
- Misses 1510 1512 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
When deleting an object in the image gallery on a large project, the UI may block for 20 seconds or more.
ImageGallery model is the cameraInit viewpoints attribute (a listAttribute).
When removing an image, listAttribute remove is called.
remove emit valueChanged, which tells the imageGallery that the whole model must be invalidated and reloaded.
I propose to replace the emission of the valueChanged signal with the direct call of the slot _onAttributeChanged.
Does not break the tests, but i am not sure if it does not have any collateral effects.