Remove CyclicDependencyError on backEdge during the DFS process#2977
Merged
CedricThebault merged 1 commit intodevelopfrom Jan 15, 2026
Merged
Remove CyclicDependencyError on backEdge during the DFS process#2977CedricThebault merged 1 commit intodevelopfrom
CyclicDependencyError on backEdge during the DFS process#2977CedricThebault merged 1 commit intodevelopfrom
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #2977 +/- ##
===========================================
- Coverage 79.67% 79.61% -0.07%
===========================================
Files 64 64
Lines 8602 8595 -7
===========================================
- Hits 6854 6843 -11
- Misses 1748 1752 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CedricThebault
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This removes a partial check on cyclic dependencies in the DFS process that was introduced in #2965 and that causes erroneous exceptions even in cases where no cyclic dependency is present.