Skip to content

Remove CyclicDependencyError on backEdge during the DFS process#2977

Merged
CedricThebault merged 1 commit intodevelopfrom
fix/cyclicDependencyDetection
Jan 15, 2026
Merged

Remove CyclicDependencyError on backEdge during the DFS process#2977
CedricThebault merged 1 commit intodevelopfrom
fix/cyclicDependencyDetection

Conversation

@cbentejac
Copy link
Copy Markdown
Contributor

Description

This removes a partial check on cyclic dependencies in the DFS process that was introduced in #2965 and that causes erroneous exceptions even in cases where no cyclic dependency is present.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.61%. Comparing base (83902d6) to head (91b6bf0).
⚠️ Report is 2 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
meshroom/core/graph.py 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2977      +/-   ##
===========================================
- Coverage    79.67%   79.61%   -0.07%     
===========================================
  Files           64       64              
  Lines         8602     8595       -7     
===========================================
- Hits          6854     6843      -11     
- Misses        1748     1752       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CedricThebault CedricThebault merged commit da30eaf into develop Jan 15, 2026
3 of 4 checks passed
@CedricThebault CedricThebault deleted the fix/cyclicDependencyDetection branch January 15, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants