[core] Load valid plugins even if they contain no node#2989
Merged
servantftransperfect merged 1 commit intodevelopfrom Feb 5, 2026
Merged
[core] Load valid plugins even if they contain no node#2989servantftransperfect merged 1 commit intodevelopfrom
servantftransperfect merged 1 commit intodevelopfrom
Conversation
With this commit, a plugin that does not contain any `NodePlugin` may be loaded. Prior to it, if no node was found, the plugin was not added to the list of plugins to load, even if it was valid. We can now load plugins that for example only have specific templates.
servantftransperfect
approved these changes
Feb 5, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2989 +/- ##
========================================
Coverage 81.67% 81.67%
========================================
Files 69 69
Lines 9144 9144
========================================
Hits 7468 7468
Misses 1676 1676 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows to properly load plugins that do not contain any nodes. As long as there is a Python package in the
meshroomfolder of the plugin, even if it is empty, the plugin will be fully loaded. This can be useful for example when wanting to load a plugin that only provides templates.