Skip to content

[ui] Homepage: Replace all left occurrences of gridView with homepageGridView#2991

Merged
Alxiice merged 1 commit intodevelopfrom
fix/homepageRefToGridView
Feb 9, 2026
Merged

[ui] Homepage: Replace all left occurrences of gridView with homepageGridView#2991
Alxiice merged 1 commit intodevelopfrom
fix/homepageRefToGridView

Conversation

@cbentejac
Copy link
Copy Markdown
Contributor

Description

This pull request updates the thumbnail refresh logic in the Homepage.qml file to use the correct grid view reference. This ensures that thumbnails are updated reliably in the homepage grid.

@cbentejac cbentejac added this to the Meshroom 2026.1.0 milestone Feb 6, 2026
@cbentejac cbentejac requested a review from Alxiice February 6, 2026 17:30
@cbentejac cbentejac self-assigned this Feb 6, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.67%. Comparing base (35381b9) to head (0ec1ccd).
⚠️ Report is 2 commits behind head on develop.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2991   +/-   ##
========================================
  Coverage    81.67%   81.67%           
========================================
  Files           69       69           
  Lines         9144     9144           
========================================
  Hits          7468     7468           
  Misses        1676     1676           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the homepage thumbnail refresh wiring so thumbnail cache notifications target the correct GridView instance, improving reliability of thumbnail updates on the homepage projects grid.

Changes:

  • Replaced gridView references with homepageGridView inside the ThumbnailCache.onThumbnailCreated handler.
  • Updated the fallback scan loop to iterate over homepageGridView items.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread meshroom/ui/qml/Homepage.qml
@Alxiice Alxiice merged commit 42e16c0 into develop Feb 9, 2026
10 checks passed
@Alxiice Alxiice deleted the fix/homepageRefToGridView branch February 9, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants