SequencePlayer: replace basic Slider with a TimelineSlider component#3059
Open
SequencePlayer: replace basic Slider with a TimelineSlider component#3059
Conversation
Copilot created this pull request from a session on behalf of
fabiencastan
March 27, 2026 22:18
View session
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3059 +/- ##
===========================================
- Coverage 83.38% 83.36% -0.03%
===========================================
Files 73 73
Lines 9874 9880 +6
===========================================
+ Hits 8233 8236 +3
- Misses 1641 1644 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Agent-Logs-Url: https://github.com/alicevision/Meshroom/sessions/995f742e-a390-4c02-9248-78f308576f07 Co-authored-by: fabiencastan <153585+fabiencastan@users.noreply.github.com>
c72d769 to
d2444c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SequencePlayer used a plain
Sliderwith an inline custom background. This replaces it with a dedicatedTimelineSlidercomponent that looks and behaves like a real timeline.Description
Introduces
TimelineSlider, aSlidersubclass with timeline-style visuals, and wires it intoSequencePlayer.Features list
palette.highlight) replaces the default circular thumbcachedFramesproperty on the componentTimelineSliderregistered inControls/qmldirfor reuseImplementation remarks
TimelineSliderkeeps the same public interface asSlider(from,to,value,stepSize,snapMode,live,pressed) so the drop-in replacement inSequencePlayerrequires no logic changes — only the inlinebackground/cacheViewblock is removed.The cached-frame x-position formula (
modelData.x * frameLength) is intentionally unchanged from the original:cachedFramescarries 0-based frame indices relative to sequence start, matchingframeRange.min = 0in the existing model.The ruler tick interval is chosen so there are ~10–15 major ticks regardless of sequence length, preventing label crowding without requiring dynamic width measurement.