Skip to content

[tests] Fix test_submit when launched through a rez env#3078

Merged
cbentejac merged 2 commits intodevelopfrom
bugfix/issues_with_pytest_through_rez
Apr 27, 2026
Merged

[tests] Fix test_submit when launched through a rez env#3078
cbentejac merged 2 commits intodevelopfrom
bugfix/issues_with_pytest_through_rez

Conversation

@Alxiice
Copy link
Copy Markdown
Contributor

@Alxiice Alxiice commented Apr 14, 2026

Description

When we launched the test_submit test from a rez env we have a Compatibility issue error :

  • the test registers the submitters
  • the local farm submitter is initialized
  • we list local packages
  • if we are on a rez env then we will wrap all commands with rez

Then when the task launches :

  • before the task, the farm sets the MESHROOM_PLUGINS_PATH
  • But when the command executes, it starts with a rez env command
  • If one of the packages in the env have a env.MESHROOM_PLUGINS_PATH.append(...) then it starts by resetting the MESHROOM_PLUGINS_PATH env variable, and we loose the content that we set here from the farm process.

Fix

The way I fixed the issue is by resetting rez variables before the test process, and therefore when the submitter is registered in the test, tasks are created without rez. And then, we have the correct value for MESHROOM_PLUGINS_PATH and the test succeeds.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.47%. Comparing base (b55440c) to head (2b8435f).
⚠️ Report is 3 commits behind head on develop.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3078   +/-   ##
========================================
  Coverage    83.47%   83.47%           
========================================
  Files           81       81           
  Lines        10300    10301    +1     
========================================
+ Hits          8598     8599    +1     
  Misses        1702     1702           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Alxiice Alxiice force-pushed the bugfix/issues_with_pytest_through_rez branch from 60c9ae6 to 6150c66 Compare April 14, 2026 16:14
@Alxiice Alxiice force-pushed the bugfix/issues_with_pytest_through_rez branch from 6150c66 to 05e78d8 Compare April 17, 2026 13:29
@sonarqubecloud
Copy link
Copy Markdown

@Alxiice Alxiice force-pushed the bugfix/issues_with_pytest_through_rez branch from 05e78d8 to 8750415 Compare April 27, 2026 14:19
@Alxiice Alxiice force-pushed the bugfix/issues_with_pytest_through_rez branch from 8750415 to 2b8435f Compare April 27, 2026 14:20
@cbentejac cbentejac added this to the Meshroom 2026.1.0 milestone Apr 27, 2026
@cbentejac cbentejac merged commit a4ffad7 into develop Apr 27, 2026
8 checks passed
@cbentejac cbentejac deleted the bugfix/issues_with_pytest_through_rez branch April 27, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants