Skip to content

[core] fileUtils: Never call group() on an empty match#3084

Merged
fabiencastan merged 1 commit intodevelopfrom
fix/resolvePath
Apr 23, 2026
Merged

[core] fileUtils: Never call group() on an empty match#3084
fabiencastan merged 1 commit intodevelopfrom
fix/resolvePath

Conversation

@cbentejac
Copy link
Copy Markdown
Contributor

Description

This PR addresses an issue when attempting to display images in the 2D viewer while there are several CameraInit nodes in the scene.

Ensuring match is not None before calling group() prevents an AttributeError that causes the display in the viewer of the selected image to fail:

frameId_str = match.group("FRAMEID_STR")
                  ^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'group'

Ensuring `match` is not `None` before calling `group()` prevents an
AttributeError that causes the display in the viewer of the selected
image to fail.
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.47%. Comparing base (760a240) to head (7ec748e).
⚠️ Report is 6 commits behind head on develop.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3084      +/-   ##
===========================================
+ Coverage    83.40%   83.47%   +0.06%     
===========================================
  Files           81       81              
  Lines        10259    10300      +41     
===========================================
+ Hits          8557     8598      +41     
  Misses        1702     1702              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fabiencastan fabiencastan merged commit b55440c into develop Apr 23, 2026
8 checks passed
@fabiencastan fabiencastan deleted the fix/resolvePath branch April 23, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants