Enable building LEMON with C++20 #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the register keyword used in random.h. As it was only used as a compiler hint, this does not change behaviour. Signed-off-by: Philipp Remy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the project to be build with
CMAKE_CXX_STANDARD=20.It previously failed because it used the removed
registerkeyword inrandom.h. Asregisterwas only a compiler hint, it does to change any program logic.This paves the way to allow building LEMON in AliceVision as an embedded dependency with the general
CMAKE_CORE_BUILD_FLAGS, which setCMAKE_CXX_STANDARD=20(see here).