Lens calibration: Add CCTag support #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
August 19, 2016 13:57
…sCalibration_cleanParams Conflicts: src/lensCalibration/LensCalibration.cpp src/lensCalibration/LensCalibrationPlugin.cpp
* display Grid in overlay * display CCTags: ellipse and ID * fixes for param attributes * don't clear data when input clip change (we may loose a lot of work with a false manipulation) * add popup when the calibration is finished * rename CCTAG to ASYMMETRIC_CCTAG * fix for Nuke to force a UI refresh of the NbCheckersDetected param value
ghost
added
the
| @@ -12,6 +12,8 @@ target_include_directories(mvg | |||
| ${OPENMVG_INCLUDE_DIRS} | |||
| ${Boost_INCLUDE_DIRS} | |||
| ${OpenCV_INCLUDE_DIRS} | |||
| ${CCTAG_INCLUDE_DIRS} | |||
| ${TBB_INCLUDE_DIRS} | |||
There was a problem hiding this comment.
@fabiencastan is it still necessary? I saw that u remove that. (I mean, until that one is merged we need this i guess)
There was a problem hiding this comment.
Yes, now it's needed because we use CCTag library directly (to retrieve the ellipse). Before that, the usage of CCTag was hidden behind openMVG.
There was a problem hiding this comment.
I meant the tbb include. Is the tbb included in a header of cctag??
There was a problem hiding this comment.
I removed one in my cctag PR. Need to check again if it's still needed here.
ghost
requested a review
from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.