Skip to content

[testing] Compare various descriptors#115

Closed
griwodz wants to merge 10 commits intodevelopfrom
feature/compareScripts
Closed

[testing] Compare various descriptors#115
griwodz wants to merge 10 commits intodevelopfrom
feature/compareScripts

Conversation

@griwodz
Copy link
Copy Markdown
Member

@griwodz griwodz commented Oct 16, 2020

Description

The test script runs VLFeat and PopSift on one or more images and creates the descriptors with orientations.
compareSiftFiles.cpp performs a brute force comparison of the output files and outputs sorted files and some distance computations.
These are then transformed bash and awk and rendered visually with gnuplot.

Features list

  • New binary that compares two files containing SIFT descriptors. VLFeat and Matlab syntax supported.
  • Scripts that compare VLFeat-compatible PopSift behaviour with original VLFeat behaviour. Requires new command line options of PR VLFeat compatibility #114 before they can work.

Implementation remarks

@griwodz griwodz self-assigned this Oct 16, 2020
@griwodz griwodz changed the base branch from fix/vlfeatCompliance2 to develop December 29, 2020 10:03
@griwodz griwodz force-pushed the feature/compareScripts branch from a0dbbad to 71d4ab7 Compare December 29, 2020 10:04
@griwodz
Copy link
Copy Markdown
Member Author

griwodz commented Dec 29, 2020

@simogasp Is there any way of telling CodeFactor to check again after fixing the complaints? It keeps pointing me at a line where a very long function started when this PR was first created.

@simogasp
Copy link
Copy Markdown
Member

@griwodz there is a re-run link in https://github.com/alicevision/popsift/pull/115/checks
Also if u login u can ignore the issue if it is not important or pertinent

@griwodz
Copy link
Copy Markdown
Member Author

griwodz commented Dec 30, 2020

@simogasp Right now the checks have passed and I do probably not see any re-run links because of that. But I'm sure that I saw it before and pressing it didn't do the right thing. The error kept returning, still reporting a missing null-pointer check from a much earlier commit. Is it possible that there is a processing queue and the new commit were not really checked?

@griwodz griwodz requested a review from simogasp January 4, 2021 17:36
@griwodz griwodz force-pushed the feature/compareScripts branch from 490ea75 to 8090688 Compare January 5, 2021 05:53
Comment thread CMakeLists.txt Outdated
message(STATUS "Building in ${CMAKE_BUILD_TYPE} configuration")
endif()

include(FindOpenACC)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we using OpenACC?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't. It would simplify the grid filter, but the compiler is not part of the mainstream CUDA SDK yet. It should not be in the PR.

@griwodz griwodz force-pushed the feature/compareScripts branch from d1383ce to cb24f0d Compare March 7, 2021 08:13
@griwodz griwodz force-pushed the feature/compareScripts branch from d74fe40 to 45247e7 Compare March 7, 2021 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants