Skip to content

Feature/opt ignore threshold#128

Closed
griwodz wants to merge 8 commits intodevelopfrom
feature/optIgnoreTreshold
Closed

Feature/opt ignore threshold#128
griwodz wants to merge 8 commits intodevelopfrom
feature/optIgnoreTreshold

Conversation

@griwodz
Copy link
Copy Markdown
Member

@griwodz griwodz commented Feb 14, 2021

Description

In finding extrema, ignore the Edge Threshold and Peak Threshold, when their respective configuration variables are set to 0.0f or less.

Features list

  • Ignoring two checks when the respective config values are 0 or less.
  • Added getDefault functions and usage descriptions to the Config class.

Implementation remarks

@griwodz
Copy link
Copy Markdown
Member Author

griwodz commented Feb 14, 2021

Codacy complains but I think that it has not run. At least the only issue I can see is not real and seems to belong to an old commit.

@griwodz griwodz force-pushed the feature/optIgnoreTreshold branch from 440295a to 96655e4 Compare March 6, 2021 23:33
@griwodz griwodz force-pushed the feature/optIgnoreTreshold branch from 96655e4 to f8de48f Compare March 7, 2021 00:14
@griwodz griwodz requested review from fabiencastan and simogasp March 7, 2021 12:49
@griwodz griwodz self-assigned this Mar 7, 2021
@griwodz griwodz added this to the v1.0.0 milestone Mar 7, 2021
@griwodz griwodz force-pushed the feature/optIgnoreTreshold branch from f8de48f to bb901d7 Compare March 7, 2021 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants