[sift] removed support for the old option for Gaussian filter width computation opencv #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extrema are searched from 3x3x3 blocks of pixels in the DoG pyramid. The dead code could search in interpolated pixels, which never made sense. The code was always #undef'ed.
OpenCV used quite narrow Gaussian filters when PopSift was first written. This computation was adopted for compatibility reasons, but the missing elements in the filter do actually have a noticable impact. The other modes are more accurate.
Features list
Implementation remarks
There are still Gaussian filter modes that should be retired. The fixed filter with width 9 provides bad quality, while the fixed filter with width 15 is needlessly slow.