Conversation
Member
Author
|
Actually I did also fix an incorrectly placed __syncthreads() call in descriptor extraction. |
griwodz
force-pushed
the
dev/fixNewWarp
branch
from
3b5fec3 to
898b28f
Compare
griwodz
force-pushed
the
dev/fixNewWarp
branch
from
898b28f to
7e247cb
Compare
Member
Author
|
I withdraw this PR. The important fixes are in PR #67 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PopSift orientation step failed on RTX 20 series cards.
I found one line (a conditional warp shuffle operation) that needed to be fixed.
I also added regression code for the bitonic sort function because CUDA 9 introduced a new C++ approach for warp synchronization. This code is the future, better to get used to it.