Skip to content

Examples on windows#86

Merged
simogasp merged 2 commits intodevelopfrom
fix/apps_win
Apr 20, 2020
Merged

Examples on windows#86
simogasp merged 2 commits intodevelopfrom
fix/apps_win

Conversation

@fabiencastan
Copy link
Copy Markdown
Member

@fabiencastan fabiencastan commented Apr 20, 2020

Features list

  • Build fix for MSVC on samples
  • Build samples on appveyor

@fabiencastan fabiencastan marked this pull request as ready for review April 20, 2020 20:16
@fabiencastan fabiencastan requested a review from simogasp April 20, 2020 20:16
@simogasp simogasp added this to the v1.0.0 milestone Apr 20, 2020
simogasp
simogasp approved these changes Apr 20, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@simogasp simogasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simogasp simogasp merged commit 42bda27 into develop Apr 20, 2020
@simogasp simogasp deleted the fix/apps_win branch April 20, 2020 20:19
@simogasp simogasp self-assigned this Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simogasp simogasp simogasp approved these changes

Assignees

@simogasp simogasp

Labels

scope:build windows

Projects

None yet

Milestone

v1.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@fabiencastan @simogasp