Add crate description to generated configs #2028
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes alire-project#1931. WIP! Not sure if we should be properly escaping strings before placing them in Ada/GPR/C literals.
ulahello
changed the title
ulahello
force-pushed
the
ula/crate-description-in-configs
branch
from
797def6 to
72c11f4
Compare
Fabien-Chouteau
requested changes
Dec 17, 2025
| declare | ||
| Version_Str : constant String := Rel.Version.Image; | ||
|
|
||
| -- TODO(ula): not properly escaped for Ada, GPR, nor C. for |
Member
There was a problem hiding this comment.
@ulahello This is a good addition but the TODO must be addressed.
Author
There was a problem hiding this comment.
Thanks for taking a look, I'll see if there's existing crates that do this.
edit: the alternative is of course writing it by hand, but I'd want to take a look at the relevant specs to make sure it's correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1931.
The
descriptionkey fromalire.tomlis now copied into the generated crate configuration files.TODOs
PR creation checklist
doc/user-changes.mdhas been updated, if there are user-visible changes.doc/catalog-format-spec.mdhas been updated, if applicable.BREAKING.mdhas been updated for major changes inalr, minor/major in catalog format.