Fix: GridifyQueryBuilder.build() is not idempotent#320
Merged
alirezanet merged 7 commits intomasterfrom Mar 7, 2026
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix TS query builder idempotency issue
Fix: GridifyQueryBuilder.build() is not idempotent
Mar 7, 2026
alirezanet
reviewed
Mar 7, 2026
alirezanet
requested changes
Mar 7, 2026
alirezanet
requested changes
Mar 7, 2026
Owner
alirezanet
left a comment
There was a problem hiding this comment.
revert your last commit. I don't want to ignore the lock files.
Co-authored-by: alirezanet <7004080+alirezanet@users.noreply.github.com>
Co-authored-by: alirezanet <7004080+alirezanet@users.noreply.github.com>
Co-authored-by: alirezanet <7004080+alirezanet@users.noreply.github.com>
7adce05 to
00c3765
Compare
alirezanet
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build()accumulated filter expressions directly intothis.query.filtervia+=. Calling it more than once appended all filter expressions again on top of the previously built result, producing duplicate filters.Root Cause
On the second
build()call,this.query.filteralready held the first result, so all expressions were appended again.Fix
Build the filter into a local variable; assign to
this.query.filteronly once at the end ofbuild().This makes
build()a pure projection fromfilteringExpressions→ query string with no cumulative side effects.Type of change
Checklist
Original prompt
build()multiple times does not yield the same result #277✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.